ZoopaMario/backup-automation
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Refactor code base to make linter runs succeed #5

Merged
ZoopaMario merged 1 commit from refactor_for_linter into main 2024-12-29 19:36:43 +01:00
Conversation 0 Commits 1 Files changed 9 +149 -160
ZoopaMario commented 2024-12-29 15:26:15 +01:00
Owner
Copy link

This commit refactors the codebase in order to make the shellcheck
workflow pass.

It also makes shellcheck ignore common info messages, specifically:

This commit refactors the codebase in order to make the shellcheck workflow pass. It also makes shellcheck ignore common info messages, specifically: - https://www.shellcheck.net/wiki/SC1091 -- Not following: ./../logger.sh: op... - https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...
ZoopaMario added 1 commit 2024-12-29 15:26:16 +01:00
Refactor code to make linter runs succeed
Some checks failed
Check Commit Messages / check-commit-message (pull_request) Successful in 15s
Details
Lint Bash Scripts / lint-bash (pull_request) Failing after 24s
Details
0005432b69 
This commit refactors the codebase in order to make the shellcheck
workflow pass.

It also makes shellcheck ignore common info messages, specifically:
- https://www.shellcheck.net/wiki/SC1091 -- Not following: ./../logger.sh: op...
- https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...
ZoopaMario force-pushed refactor_for_linter from 0005432b69 to aaf9ecfc1d 2024-12-29 15:40:52 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from aaf9ecfc1d to 166a947497 2024-12-29 15:45:30 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from 166a947497 to fad0b9d526 2024-12-29 15:47:05 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from fad0b9d526 to 95fd7c50b7 2024-12-29 15:49:38 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from 95fd7c50b7 to 859ef2e93f 2024-12-29 15:51:17 +01:00 Compare
ZoopaMario added 1 commit 2024-12-29 15:54:04 +01:00
iasdest123
Some checks failed
Lint Bash Scripts / lint-bash (push) Successful in 24s
Details
Check Commit Messages / check-commit-message (pull_request) Failing after 34s
Details
Lint Bash Scripts / lint-bash (pull_request) Successful in 22s
Details
d961620bcf 
asd
ZoopaMario force-pushed refactor_for_linter from d961620bcf to eb1e69b49c 2024-12-29 15:58:04 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from eb1e69b49c to f1172682bb 2024-12-29 16:08:35 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from f1172682bb to b25f8985cd 2024-12-29 16:16:12 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from b25f8985cd to 6bdede9607 2024-12-29 16:16:33 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from 6bdede9607 to 2caa2302b5 2024-12-29 19:14:50 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from 2caa2302b5 to 0e985dc381 2024-12-29 19:20:24 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from 0e985dc381 to b5f78208c4 2024-12-29 19:29:23 +01:00 Compare
ZoopaMario force-pushed refactor_for_linter from b5f78208c4 to 6f394a867a 2024-12-29 19:32:28 +01:00 Compare
ZoopaMario merged commit 6f394a867a into main 2024-12-29 19:36:43 +01:00
ZoopaMario deleted branch refactor_for_linter 2024-12-29 19:36:44 +01:00
ZoopaMario changed title from Refactor code to make linter runs succeed to Refactor code base to make linter runs succeed 2024-12-30 06:55:36 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ZoopaMario/backup-automation#5
No description provided.
Delete branch "refactor_for_linter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?