Refactor code to make linter runs succeed

This commit refactors the codebase in order to make the shellcheck
workflow pass.

It also makes shellcheck ignore common info messages, specifically:
- https://www.shellcheck.net/wiki/SC1091 -- Not following: ./../logger.sh: op...
- https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...

.forgejo/workflows/lint-bash.yml

@@ -18,27 +18,15 @@ jobs:
       - name: Checkout Code
         uses: https://code.forgejo.org/actions/checkout@v4
         with:
-          fetch-depth: 0
+          fetch-depth: 0  # Fetch the entire history to avoid REST API reliance
 
       - name: Install ShellCheck
         run: |
           apt-get update && apt-get install -y shellcheck
 
-      - name: Find Shell Scripts
+      - name: Lint Bash Scripts
-        id: find-scripts
         run: |
-          echo "Searching for shell scripts..."
+          echo "Linting Bash scripts..."
-          find . -name '*.sh' -print0 > shell-scripts.list
+          find . -name '*.sh' -print0 | xargs -0 shellcheck -x --exclude=SC1091 --exclude=SC2015
-
-      - name: Run ShellCheck in Script Directories
-        run: |
-          echo "Running ShellCheck in each script's directory..."
-          while IFS= read -r -d '' script; do
-            echo "Checking $script"
-            script_dir=$(dirname "$script")
-            script_name=$(basename "$script")
-            # Change to the script's directory and run ShellCheck
-            (cd "$script_dir" && shellcheck -x "$script_name")
-          done < shell-scripts.list
 
 

duplicati/duplicati-backup.sh

@@ -24,7 +24,6 @@ while getopts ":f:h:u:p:m:b:" opt; do
 done
 
 # Create a temporary file for the encrypted archive
-# shellcheck disable=SC2015
 TMP_FILENAME=duplicati_db-$(date +"%Y%m%d").bak &&
 TMP_FILEPATH="$SCRIPT_ABS_LOCATION" || { log "Error: Failed to create a temporary file."; exit 1; }