Refactor code to make linter runs succeed

This commit refactors the codebase in order to make the shellcheck
workflow pass.

cryptpad/cryptpad-backup.sh

@@ -11,9 +11,6 @@ source "$SCRIPT_ABS_LOCATION/../logger.sh"
 CONTAINER="cryptpad"          
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/cryptpad-backup.log"
-
 SOURCE_DIR="/mnt/data/cryptpad"
 
 # Cleanup inactive and archive files

duplicati/duplicati-backup.sh

@@ -7,65 +7,11 @@ source "$SCRIPT_ABS_LOCATION/duplicati-backup.env"
 # shellcheck disable=SC1090
 source "$SCRIPT_ABS_LOCATION/../logger.sh"
 
-# Default values
-SOURCE_DIR="/mnt/data/duplicati"
-MAX_BACKUPS=7
-BACKUP_FOLDER=""
-SSH_KEY="${SSH_KEY:-$HOME/.ssh/id_rsa}"
-LOG_FILE="$SCRIPT_ABS_LOCATION/duplicati-backup.log"
-
-# Override with command-line arguments
-while getopts ":f:h:u:p:m:b:" opt; do
-  case $opt in
-    f) SOURCE_DIR="$OPTARG";;
-    h) SSH_DESTINATION="$OPTARG";;
-    u) SSH_USERNAME="$OPTARG";;
-    p) SSH_PASSWORD="$OPTARG";;
-    m) MAX_BACKUPS="$OPTARG";;
-    b) BACKUP_FOLDER="$OPTARG";;
-    \?) echo "Invalid option: -$OPTARG"; exit 1;;
-  esac
-done
-
-TMP_FILENAME="duplicati_db-$(date +"%Y%m%d").bak"
-TMP_FILEPATH="$SCRIPT_ABS_LOCATION"
-
-log "Compressing and encrypting the Duplicati Databases"
-sudo tar --absolute-names -czf - "$SOURCE_DIR" | openssl enc -aes-256-cbc -pbkdf2 -pass "pass:$BACKUP_ENCR_PASSPHRASE" > "$TMP_FILEPATH/$TMP_FILENAME" || {
-    log "Error: Failed to create encrypted archive."
-    exit 1
-}
-
-log "Fetching number of backups in destination folder"
-EXISTING_BACKUPS=$(ssh -p 23 -i "$SSH_KEY" "$SSH_USERNAME@$SSH_DESTINATION" "ls '$BACKUP_FOLDER'" | wc -l) || {
-    log "Error: Failed to count existing backups."
-    exit 1
-}
-
-if (( $EXISTING_BACKUPS > $MAX_BACKUPS )); then
-  log "Removing old backups in order to save space"
-  ssh "$SSH_USERNAME@$SSH_DESTINATION" -p 23 -i "$SSH_KEY" "ls -t $BACKUP_FOLDER | tail -n +$((MAX_BACKUPS+1)) | xargs rm" || { log "Error: Failed to remove old backups."; ex
-it 1; }
-fi
-
-log "Transferring archive to SSH Destination"
-scp -v -P 23 -i "$SSH_KEY" "$TMP_FILEPATH/$TMP_FILENAME" "$SSH_USERNAME@$SSH_DESTINATION:$BACKUP_FOLDER$TMP_FILENAME" || {
-    log "Error: Failed to transfer the encrypted archive."
-    exit 1
-}
-
-log "Cleaning up temporary files"
-rm "$TMP_FILEPATH/$TMP_FILENAME" || {
-    log "Error: Failed to remove the temporary file."
-    exit 1
-}
-
-log "Backup completed successfully."
-
 SOURCE_DIR="/mnt/data/duplicati"
 
 # Set default values for parameters
 MAX_BACKUPS=7
+BACKUP_FOLDER=""
 
 # Override default values with command-line arguments
 while getopts ":f:h:u:p:m:b:" opt; do
@@ -81,25 +27,23 @@ while getopts ":f:h:u:p:m:b:" opt; do
 done
 
 # Create a temporary file for the encrypted archive
-TMP_FILENAME="duplicati_db-$(date +"%Y%m%d").bak"
-TMP_FILEPATH="$SCRIPT_ABS_LOCATION"
-if [ -z "$TMP_FILEPATH" ]; then
-    log "Error: TMP_FILEPATH is not set."; exit 1
-fi
+# shellcheck disable=SC2015
+TMP_FILENAME=duplicati_db-$(date +"%Y%m%d").bak &&
+TMP_FILEPATH="$SCRIPT_ABS_LOCATION" || { log "Error: Failed to create a temporary file."; exit 1; }
 
 # Create the encrypted archive using tar and openssl
 log "Compressing and excrypting the Duplicati Databases"
-sudo tar --absolute-names -czf - "$SOURCE_DIR" | openssl enc -aes-256-cbc -pbkdf2 -pass "pass:$BACKUP_ENCR_PASSPHRASE" > "$TMP_FILEPATH/$TMP_FILENAME" || { log "Error: Failed to create encrypted archive."; exit 1; }
+sudo tar -czf - "$SOURCE_DIR" | openssl enc -aes-256-cbc -pbkdf2 -pass "pass:$BACKUP_ENCR_PASSPHRASE" > "$TMP_FILEPATH/$TMP_FILENAME" || { log "Error: Failed to create encrypted archive."; exit 1; }
 
 
 # Connect to the backup host and count the number of existing backups
 log "Fetching number of backups in destination folder"
-EXISTING_BACKUPS=$(ssh "$SSH_USERNAME@$SSH_DESTINATION" -p 23 -i "$SSH_KEY" 'ls' | sudo wc -l) || { log "Error: Failed to count existing backups."; exit 1; }
+EXISTING_BACKUPS=$(ssh "$SSH_USERNAME@$SSH_DESTINATION" -p 23 -i "$SSH_KEY ls" | sudo wc -l) || { log "Error: Failed to count existing backups."; exit 1; }
 
 # Remove old backups if there are too many
 if (( EXISTING_BACKUPS > MAX_BACKUPS )); then
   log "Removing old backups in order to save space"
-  ssh "$SSH_USERNAME@$SSH_DESTINATION" -p 23 -i "$SSH_KEY" "ls -t $BACKUP_FOLDER | tail -n +$((MAX_BACKUPS+1)) | xargs rm" || { log "Error: Failed to remove old backups."; exit 1; }
+  ssh "$SSH_USERNAME@$SSH_DESTINATION" -p 23 -i "$SSH_KEY ls -t $BACKUP_FOLDER | tail -n +$((MAX_BACKUPS+1)) | xargs rm" || { log "Error: Failed to remove old backups."; exit 1; }
 fi
 
 # Transfer the encrypted archive to the backup host using scp

forgejo/forgejo-backup.sh

@@ -11,9 +11,6 @@ source "$SCRIPT_ABS_LOCATION/../logger.sh"
 APP_CONTAINER="forgejo"
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/forgejo-backup.log"
-
 SOURCE_DIR="/mnt/data/forgejo"
 
 # Stop forgejo container 

immich/immich-backup.sh

@@ -11,9 +11,6 @@ source "$SCRIPT_ABS_LOCATION/../logger.sh"
 DB_CONTAINER="immich_postgres"          
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/immich-backup.log"
-
 # Database Settings
 DB_USER="postgres"
 

nextcloud/nextcloud-backup.sh

@@ -12,9 +12,6 @@ APP_CONTAINER="nextcloud-app"
 DB_CONTAINER="nextcloud-db"          
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/nextcloud-backup.log"
-
 # Database Settings
 DB_USER="nextcloud"          
 

portainer/portainer-backup.sh

@@ -11,9 +11,6 @@ source "$SCRIPT_ABS_LOCATION/../logger.sh"
 APP_CONTAINER="portainer"
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/portainer-backup.log"
-
 SOURCE_DIR="/volumes/portainer"
 
 # Stop portainer container 

vaultwarden/vaultwarden-backup.sh

@@ -10,15 +10,12 @@ source "$SCRIPT_ABS_LOCATION/../logger.sh"
 # Container Names 
 BACKUP_CONTAINER="duplicati"   
 
-# Log file
-LOG_FILE="$SCRIPT_ABS_LOCATION/vaultwarden-backup.log"
-
 SOURCE_DIR="/mnt/data/vaultwarden"
 
 # Dump Database
 log "Dumping vaultwarden database..."
 DB_TMP_BAK_NAME=vaultwarden-db_$(date +"%Y%m%d").sqlite3
-sqlite3 "$SOURCE_DIR/db.sqlite3" ".backup $SOURCE_DIR/$DB_TMP_BAK_NAME" || { log "Error: Failed to dump the Nextcloud database."; exit 1; }
+sqlite3 "$SOURCE_DIR/db.sqlite3 .backup '$SOURCE_DIR/$DB_TMP_BAK_NAME'" || { log "Error: Failed to dump the Nextcloud database."; exit 1; }
 
 # Backup all files to target destination
 log "Backing up vaultwarden files and database..."